Don\'t add profile dependencies to required_by array of modules #2697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks reasonable at first glance. We need a patch for master branch before this gets merged. Master branch is much simpler. See https://github.com/drush-ops/drush/blob/master/src/Commands/PmCommands.php |
This was referenced Dec 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the patch in D.O Issue#1356276, it's possible for more than one profile to be installed. Dependencies of profiles have never prevented a module from being uninstalled, but the logic used in pm-uninstall only makes that exception for the active profile.
This patch completely removes profiles from the
required_bykey in the modules list provided bydrush_get_modules(). If the patch in D.O Issue#1356276 is applied, it uses theprofile_handlerservice to get an array of installed modules. Otherwise, it usesdrupal_get_profile()to emulate that behavior.